search

dataesr / react-dsfr

Non-official React components of the official french Système de Design de l'État.
https://dataesr.github.io/react-dsfr/
MIT License
44 stars 22 forks source link

Component Card -> prop target="_blank" #291

Open Mihoub2 opened 1 year ago

Mihoub2 commented 1 year ago

Hi!

I recently used the component "Card" to make an external link and I noticed that there where no prop to open the link in another window.

Would it be possible to add this prop ?

Thanks for you work!

MustThinkOfAName commented 1 year ago

Fun coincidence, I was looking at the very same thing yesterday; as far as I know the official dsfr doc says nothing about that; I'd even say they implicitly discourage it by saying "La carte est un lien vers une page éditoriale dont elle donne un aperçu". I'd say that page éditoriale is meant to be internal content.

But the subject is absolutely up to debate and I could be wrong! Are you part of the dsfr slack community? If so, you could ask them if we are meant to be allowed to open an external link using cards. Then we could easily implement it. I'm out of the office today so without access to slack.