search

datafaker-net / datafaker

Generating fake data for the JVM (Java, Kotlin, Groovy) has never been easier!
https://www.datafaker.net
Apache License 2.0
1.09k stars 151 forks source link

Fixed airport code. #1243

Closed bodiam closed 1 month ago

bodiam commented 1 month ago

Hi all,

I don't think the fix here is correct: https://github.com/datafaker-net/datafaker/pull/1241. While N55 might be a valid airport code, it's not a valid ICAO code, which is what the method returns:

    /**
     * Returns an airport ICAO code.
     * See also: <a href="https://en.wikipedia.org/wiki/List_of_airports_by_ICAO_code:_A">https://en.wikipedia.org/wiki/List_of_airports_by_ICAO_code:_A</a>
     */
    public String airport() {
        return resolve("aviation.airport");
    }
image