Password generation does not always contain a lowercase letter

[andriy-lendyel]

Password generation does not always contain a lowercase letter. It would be nice to fix this. Here is the test to reproduce this issue.

import net.datafaker.Faker;
import org.junit.jupiter.api.RepeatedTest;

class PasswordTest {

    private static Faker FAKER = new Faker();

    @RepeatedTest(100)
    void passwordTest() {
        String password = FAKER.internet().password(8, 16, true, true, true);

        assertTrue(
            password.chars().anyMatch(i -> Character.isLetter(i) && Character.isLowerCase(i)),
            password + " password should contain lower case character."
        );
    }
}

[kingthorin]

I guess we could add another method with a fourth Boolean but really logically someone could very well choose a password that is full caps 🤷‍♂️

Also in the next release we'll be deprecating the password methods and suggesting Text#text(Text.TextRuleConfig) instead.

• datafaker-net/datafaker#1245
• datafaker-net/datafaker#1246

[snuyanzin]

nobody says that internet().passwordgives you such guarantee, if you need such guarantee then use Text#text(Text.TextRuleConfig) as mentioned above

[crimsonvspurple]

I guess we could add another method with a fourth Boolean but really logically someone could very well choose a password that is full caps 🤷‍♂️

Also in the next release we'll be deprecating the password methods and suggesting Text#text(Text.TextRuleConfig) instead.

• Mark Internet#pass deprecated #1245
• Add doc about advanced char sequence generation #1246

Hi.

Is it possible to make the new pass recommendation (TextSymbolsBuilder...) to optionally utilize SecureRandom? If not, will you please add this feature?

My apologies. I didn't notice the base faker constructor can take a random as parameter! thank you!