search

datafaker-net / datafaker

Generating fake data for the JVM (Java, Kotlin, Groovy) has never been easier!
https://www.datafaker.net
Apache License 2.0
1.09k stars 151 forks source link

Add boardgame provider #1251

Closed jensGiehl closed 1 month ago

jensGiehl commented 1 month ago

Data taken from boardgamegeek.com and recommend.games

jensGiehl commented 1 month ago

This should probably be an Entertainment provider

For Entertainment, I wasn't sure if it belonged there, since only movies are listed there so far.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.95%. Comparing base (b37c566) to head (c0ee818). Report is 152 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1251 +/- ## ============================================ - Coverage 92.35% 91.95% -0.40% - Complexity 2821 3035 +214 ============================================ Files 292 309 +17 Lines 5609 5932 +323 Branches 599 622 +23 ============================================ + Hits 5180 5455 +275 - Misses 275 319 +44 - Partials 154 158 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bodiam commented 1 month ago

Hi @jensGiehl , thanks for this contribution! Looks great, and thanks for addressing the review comments!

kingthorin commented 1 month ago

Geez you were quick. I read the comment about Entertainment and went and look, I almost told you that you merged to quickly and that there was already a Boardgame provider, then I realized the file I was looking at was only 2 minutes old 🤣