datafaker-net / datafaker

Generating fake data for the JVM (Java, Kotlin, Groovy) has never been easier!
https://www.datafaker.net
Apache License 2.0
1.09k stars 151 forks source link

fix(deps): update dependency com.googlecode.libphonenumber:libphonenumber to v8.13.39 #1254

Closed renovate[bot] closed 3 weeks ago

renovate[bot] commented 3 weeks ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.googlecode.libphonenumber:libphonenumber 8.13.38 -> 8.13.39 age adoption passing confidence

Release Notes

google/libphonenumber (com.googlecode.libphonenumber:libphonenumber) ### [`v8.13.39`](https://togithub.com/google/libphonenumber/compare/v8.13.38...v8.13.39) [Compare Source](https://togithub.com/google/libphonenumber/compare/v8.13.38...v8.13.39)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

kingthorin commented 3 weeks ago

@asolntsev any thoughts on this? I don't think it's the dependency change that caused the failure, there was a similar test failure during CI yesterday. I re-ran the job yesterday and it passed. Are we just statistically going to get this from time to time, even with 100 iterations we could sill end-up with an invalid number?

kingthorin commented 3 weeks ago

Hmmm actually all 3 failures seem to be for es_AR. This PR from today also failed: https://github.com/datafaker-net/datafaker/actions/runs/9499506796/job/26180742426?pr=1255

I'll leave them for now so you can look at the two current examples.

asolntsev commented 3 weeks ago

Grrrr... :( Yes, the test is flaky with es_AR locale. :( It starts failing stably if I increase COUNT from 100 to 1000.

I will try to fix it. At least mark this locale as unstable somehow, so that test would ignore it.

kingthorin commented 3 weeks ago

Thanks, I've restarted both for now. If/when they pass I'll merge these dep PRs.