fix: expressions resolution

datafaker-net / datafaker

Generating fake data for the JVM (Java, Kotlin, Groovy) has never been easier!

https://www.datafaker.net

Apache License 2.0

1.09k stars 151 forks source link

fix: expressions resolution #1275

Closed kingthorin closed 1 week ago

kingthorin commented 1 week ago

If an expression has arguments it shouldn't be treated as "simple".

Tweak FaverValueService logic and add test to FakerValueServiceTest.

Fixes datafaker-net/datafaker#1274

what-the-diff[bot] commented 1 week ago

PR Summary

Enhancement of Directive Evaluation in FakeValuesService In FakeValuesService.java, we've introduced a safety measure, in the form of a condition check. Now before any directive is added to the list of results, the system makes sure that it is "simple", improving the overall quality of data processed.
Additional Import in FakeValuesServiceTest In our test file FakeValuesServiceTest.java, we've added an import for LuhnCheckDigit. This is a utility which allows us to perform certain checks, therefore enhancing our testing capabilities.
New Test Method: expressionWithSingleEnumArg In order to increase the robustness of our tests, a new test method named expressionWithSingleEnumArg() has been added to FakeValuesServiceTest.java. This aims to scrutinize an expression with a single enum argument, helping reinforce our testing parameters.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.98%. Comparing base (b37c566) to head (d51e19c). Report is 173 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1275 +/- ## ============================================ - Coverage 92.35% 91.98% -0.37% - Complexity 2821 3092 +271 ============================================ Files 292 310 +18 Lines 5609 6053 +444 Branches 599 637 +38 ============================================ + Hits 5180 5568 +388 - Misses 275 323 +48 - Partials 154 162 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

panilya commented 1 week ago

@kingthorin Thank you for fixing it!

kingthorin commented 1 week ago

No problem. I'm just trying to give the other devs a chance to see it incase I've overlooked something. If there's nothing else in the next few days I'll go ahead and merge it.

asolntsev commented 1 week ago

@kingthorin I've tried your fix: works for me.

kingthorin commented 1 week ago

Great, thanks!