search

dataflownb / dfkernel

A kernel to support Python dataflows in the Jupyter Notebook environment
Other
119 stars 8 forks source link

Fix setup bug for sdist and complete package data #69

Closed colinjbrown closed 2 years ago

colinjbrown commented 2 years ago

Fixes the setup bug so that when creating source distributions we also include all the necessary library files.

colinjbrown commented 2 years ago

For future reference: setup.py is ran through twice if you create any kind of distribution, package_files correspond to what's included with any distribution while the data_files are what is placed by the kernelspec.

There's no need to include sdist in the list of installation options as it triggers on the second run through of setup.py when install is called in args.v

As a side note: Not worth treading down the path of trying to go through only a single globbing process for both data and package files