datafold / data-diff

Compare tables within or across databases
https://docs.datafold.com
MIT License
2.93k stars 262 forks source link

--cloud utilize time_column config #604

Closed dlawin closed 1 year ago

dlawin commented 1 year ago

When using datafold's cloud UI or CI integration, I can specify a time column in the dbt model config like so:https://docs.datafold.com/guides/dbt_advanced_configs#timeline

This is used to populate the timeline feature in Datafold cloud. Add functionality to pass this along to the api in --dbt --cloud diffs

We would just add it to the payload here: https://github.com/datafold/data-diff/blob/a06d698fa568d50df234481c9fdbe83a7b0077dc/data_diff/dbt.py#L290

Reference: https://docs.datafold.com/reference/cloud/rest_api

github-actions[bot] commented 1 year ago

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] commented 1 year ago

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.