search

datafold / data-diff

Compare tables within or across databases
https://docs.datafold.com
MIT License
2.95k stars 272 forks source link

Namespacing CLI options #860

Closed sar009 closed 6 months ago

sar009 commented 10 months ago

The __main__.py is blotted with a lot of CLI variables impacting readability and loose typing. So namespacing the CLI options under the class CliOptions.

sar009 commented 10 months ago

fixing https://github.com/datafold/data-diff/issues/859

sungchun12 commented 10 months ago

Can you add a fuller description on your approach in this PR? I'll plan to review this next week when it's ready!

sar009 commented 10 months ago

@sungchun12 I have updated the description please have a look.

sar009 commented 9 months ago

@sungchun12 I have addressed the review comments please take a look

sungchun12 commented 9 months ago

@sar009 thank you! I'll review later this week.

sungchun12 commented 9 months ago

Mirror this PR for the full test suite to uncover any edge cases: https://github.com/datafold/data-diff/pull/871

github-actions[bot] commented 6 months ago

This pull request has been marked as stale because it has been open for 60 days with no activity. If you would like the pull request to remain open, please comment on the pull request and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] commented 6 months ago

Although we are closing this pull request as stale, it's not gone forever. PRs can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.