update `TRIM` to `LTRIM(RTRIM(...))` for more universal query syntax

datafold / data-diff

Compare tables within or across databases

https://docs.datafold.com

MIT License

2.95k stars 272 forks source link

update `TRIM` to `LTRIM(RTRIM(...))` for more universal query syntax #886

Closed MiConnell closed 6 months ago

MiConnell commented 7 months ago

SQL Server versions before 2017 don't support trim, only ltrim and rtrim. this should be universal across databases. referenced in #885

glebmezh commented 6 months ago

Hi @MiConnell ,

I'm sorry for the delay in following up on this. Thank you for taking the time to open this PR!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

SQL Server 2019+ is now fully supported in Datafold Cloud. As for the earlier SQL Server versions, the lack of UTF8 support makes efficient diffing very hard.

-Gleb