search

datafoodconsortium / connector-codegen

An Acceleo project to generate the source code of the DFC connector into all the supported programming languages.
MIT License
3 stars 3 forks source link

Add import feature #12

Closed mkllnk closed 7 months ago

mkllnk commented 9 months ago

Import acts as reverse of export. In theory:

product == import(export(product))
json == export(import(json))

In practice, the current implementation of virtual_assembly-semantizer can't compare objects but all the attributes are the same.

mkllnk commented 8 months ago

After some back and forth around product types I decided to rebase and take a commit out that was going in the wrong direction. I also squashed some of the commits. I hope that this is a better version now.

RaggedStaff commented 7 months ago

I've only just seen this & skimmed through, so apologies if I've missed something.

@mkllnk - Not sure if you're aware of the issue around shortened URI's (use of prefixes) in some of our RDF taxonomies ? Not sure how related/impactful that is, hoping not ! :confounded: :crossed_fingers:

mkllnk commented 7 months ago

@RaggedStaff I've seen that issue, yes. But we got the import working anyway. Whenever we encounter problems like this, we just add hacky workarounds in the hope that we can remove them when the issue is resolved. So all good and I'm looking forward to a future of clean code once all bugs are fixed. :unicorn: :rainbow: :lady_beetle: