datafoodconsortium / ontology

The DFC ontology is available as OWL and RDF.
https://datafoodconsortium.gitbook.io/dfc-standard-documentation/semantic-specifications
GNU Affero General Public License v3.0
20 stars 3 forks source link

Context is missing address reference #108

Closed mkllnk closed 9 months ago

mkllnk commented 9 months ago

All attributes linking to object ids need to be mentioned in the context to contain only the URI as value.

https://github.com/datafoodconsortium/ontology/blob/5ad488514851208b4102d19da7988ecdadf6e772/context.json#L14-L16

But dfc-b:hasAddress is missing from the list.

RaggedStaff commented 9 months ago

There also seem to be a couple of duplciates (hasUnit, hasType)

@Alcoz - can we clean these up with a bugfix release ? Were we discussing other changes to the context file that we needed to implement last year ? :confused:

mkllnk commented 9 months ago

There also seem to be a couple of duplciates (hasUnit, hasType)

Those are not duplicates. One version has dfc-p as prefix and the other dfc-b. They are two different predicates.

mkllnk commented 9 months ago

Is it possible to get an ETA on this, @RaggedStaff, @lecoqlibre? Just wondering if we use our own patched context in the interim or just wait.

RaggedStaff commented 9 months ago

@mkllnk - We have an Ontology call this afternoon, will update with timeline after that.

Alcoz commented 9 months ago

New context has been generated and released in v1.10.0

mkllnk commented 9 months ago

Great to see this resolved quickly, thank you. The published context on Wordpress still needs updating. What was the reason to host it on Wordpress? Can we just link to Github?

lecoqlibre commented 9 months ago

Great to see this resolved quickly, thank you. The published context on Wordpress still needs updating. What was the reason to host it on Wordpress? Can we just link to Github?

The reason we use the WordPress is to advertise the context from the www.datafoodconsortium.org home page.

This way, we can use the following code:

"@context": "https://www.datafoodconsortium.org"

See section 6.2 Alternate Document Location from the JSON-LD spec.

But yeah we should maybe directly redirect to the context hosted on GitHub rather than hosting a copy on the WordPress site! Are you OK @mkllnk @simonLouvet @RaggedStaff?

mkllnk commented 9 months ago

Yes, I understood the alternate location and I meant using the Github location instead of the Wordpress upload location. The downsides of Github are:

So yes, I'm for using the Github location, especially since all references are to Github anyway. It makes sure that everything is in sync.

simonLouvet commented 9 months ago

github raw provide file and not json body https://raw.githubusercontent.com/datafoodconsortium/ontology/next-ontology/context.json I use little worflow an grappe.io to obtain context from github in the prototype https://grappe.io/data/api/657b001fa0ae7a293d3b30d7-dfc-context