datafoodconsortium / taxonomies

Set of taxonomies to use with the ontology like product types, units and facets.
GNU Affero General Public License v3.0
2 stars 1 forks source link

Clarify unit "cup" #8

Open mkllnk opened 1 year ago

mkllnk commented 1 year ago

https://github.com/datafoodconsortium/taxonomies/blob/f562389edd307ed5ffda3b6a55ed208ce679dfc6/measures.rdf#L1013-L1021

I hadn't seen the definition of a cup being two handfuls so far. A handful seems to be an approximate measure as well. Unfortunately, there are many definitions of a cup, ranging somewhere between 200ml (Japan) and 250ml (Metric).

With my European upbringing, living in Australia, I would choose the Metric cup but maybe we actually need to define several cups. The US Legal cup of 240 ml is a strong candidate. The others are probably not used enough to include them.

I also noticed that some concepts refer to a unit: but I couldn't find that in the context. For example: https://github.com/datafoodconsortium/taxonomies/blob/f562389edd307ed5ffda3b6a55ed208ce679dfc6/measures.rdf#L142C2-L142C45