Eval app updates - Githubissues

dataforgoodfr / 12_taxobservatory

Repository containing scripts for gathering, parsing, filtering, and visualizing declared taxes data present in Country-by-country reports

https://dataforgood.fr/projects/eutaxobservatory

MIT License

10 stars 3 forks source link

Eval app updates #83

Closed guillaume-millot closed 6 months ago

guillaume-millot commented 6 months ago

This PR contains the following fixes and improvements:

Updated yaml configuration file with more relevant extraction methodologies to benchmark
Added try catch in unstructured API to prevent Python error in case no table was extracted
Eval app improvements (see below)

Eval app improvements:

Moved PDF and REF data from right to left tabs for better clarity
New PDF viewer allowing to zoom in/out
Fixed issue with dataframes with empty headers not displayed
Display message when no table was extracted
Help tips added

guillaume-millot commented 6 months ago

@kaaloo thanks for lookup into it! Can you please clarify what you mean by "catching up" with the main branch? Perhaps give an example?

kaaloo commented 6 months ago

@kaaloo thanks for lookup into it! Can you please clarify what you mean by "catching up" with the main branch? Perhaps give an example?

Yes sure, maybe this isn't the best approach, but I noticed when running poetry install on both branches that the dependencies in this branch are not up to date. If you look at the git graph you'll see it branches out from main at a commit which took place 4 weeks ago.

So I usually update my main branch, then merge it into my feature branch before asking for review so that we are sure that the code in your PR works with the current set of dependencies. If you try it out, you'll also see the merge conflict with eval/eval_app.py.

guillaume-millot commented 6 months ago

@kaaloo ok thanks I see! Sorry about that, I created a new branch with hopefully all git history: https://github.com/dataforgoodfr/12_taxobservatory/pull/84 Lmk what you think!

guillaume-millot commented 6 months ago

Closing in favor of pull request https://github.com/dataforgoodfr/12_taxobservatory/pull/84