dataform-co / dataform-web-tracking

Dataform is a collaborative data modelling platform that enables analysts and engineers to manage complex data models in SQL
https://dataform.co
MIT License
2 stars 0 forks source link

Add compilation status indicator to the top nav bar #164

Closed lewish closed 5 years ago

lewish commented 5 years ago

As discussed, it would be useful to have a way to see project level compilation errors while editing files.

Proposal:

Optionally, if tight on space, consider moving either the focus mode controls or the documentation link into the file header bar instead.


Moved from dataform-co/dataform-co#1350 /cc @lewish

lewish commented 5 years ago

Additionally, we should add a warning popup if the user attempts to commit or push if there are compilation errors.

dwl285 commented 5 years ago

Design: add a tag on the navbar: image

That opens a popover image (For illustration purposes only, let's use the same style as the card)

GJMcGowan commented 5 years ago

@dwl285 I didn't see this ticket when making this change for the status card on the overview page.

Currently the compilation and validation errors take you to the overview page, where the status card can tell you more - is that good, or should we do the popover?

lewish commented 5 years ago

Nah you good