Templates should prompt the user before overwriting the contents of the file

dataform-co / dataform-web-tracking

Dataform is a collaborative data modelling platform that enables analysts and engineers to manage complex data models in SQL

https://dataform.co

MIT License

2 stars 0 forks source link

Templates should prompt the user before overwriting the contents of the file #169

Closed dwl285 closed 5 years ago

dwl285 commented 5 years ago

If the file is not empty, first show the user a modal: This will overwrite the contents of the current file. (OK/Cancel).

BenBirt commented 5 years ago

@dwl285 did this actually overwrite somebody's real code? The template choice UI should only be showing up for empty files / files that themselves contain literal copies of some template, if it's showing up in other circumstances then that's a bug.

BenBirt commented 5 years ago

closing in favour of https://github.com/dataform-co/dataform-co/issues/1538