dataform-co / dataform-web-tracking

Dataform is a collaborative data modelling platform that enables analysts and engineers to manage complex data models in SQL
https://dataform.co
MIT License
2 stars 0 forks source link

"Open pull request on github" opens a PR page comparing master to master #206

Closed dwl285 closed 5 years ago

dwl285 commented 5 years ago

e.g. this in the link created in the dataform-data project on the test_drop_table branch

https://github.com/dataform-co/dataform-data/compare/master...master

image

GJMcGowan commented 5 years ago

For certain branches, this will also show "push to master" when we should say "push to {branchName}"

This doesn't affect the actual push though - it's just a UI issue.

Should be "Push to Georgio"

Screenshot 2019-11-08 at 11 16 18

Clicking "Push to master" still means you have to raise a PR though:

Screenshot 2019-11-08 at 11 21 57