Stop directing the user to deleted branches

dataform-co / dataform-web-tracking

Dataform is a collaborative data modelling platform that enables analysts and engineers to manage complex data models in SQL

https://dataform.co

MIT License

2 stars 0 forks source link

Stop directing the user to deleted branches #211

Closed lewish closed 4 years ago

lewish commented 4 years ago

The project list page directs users to the last branch they were on, even if it no longer exists - let's change that logic to only direct them there if the branch still exists.

IMO we should also redirect users to the production branch if they try to go directly to a deleted branch.

Moved from dataform-co/dataform-co#1938 /cc @BenBirt

Ekrekr commented 4 years ago

There is already a redirect in place for a branch that doesn't exist (or has been deleted) to the user default, but child routes are not redirected. E.g.:

...40720/b/asd is redirected to ...40720/overview.
...40720/b/asd/overview is not redirected.

This is likely to do with the <IndexRedirect/> for branches, but I do not know enough about react routing to fix.