search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
838 stars 160 forks source link

Fix vscode entension crash in windows #1745

Closed moker-spaghetti closed 4 months ago

moker-spaghetti commented 4 months ago
  1. Changed command name in windows.
  2. Added error handling to prevent whole extension crash, even if error occured or unexpected stdout printed in the spawned process.

This is my first pull request to this project, so please let me know if you notice any issues. Also, I could not run scripts/lint with error (Invalid "extends" configuration value - could not require "tslint-config-prettier".), so I'd be grateful if you could give me any advice.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.