dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
811 stars 152 forks source link

Enable File-Specific Formatting in dataform format #1746

Closed hiracky16 closed 1 month ago

hiracky16 commented 1 month ago

resolves: https://github.com/dataform-co/dataform/issues/1747

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hiracky16 commented 1 month ago

@BenBirt

I hope this message finds you well. This is my first pull request to the repository, and I noticed that the CI check has failed. It appears that the CI process did not run at all, leading to an error.

Could you please help me understand the possible reasons for this issue? I would like to resolve any problems and ensure that the PR meets the repository's requirements.

Ekrekr commented 1 month ago

@BenBirt

I hope this message finds you well. This is my first pull request to the repository, and I noticed that the CI check has failed. It appears that the CI process did not run at all, leading to an error.

Could you please help me understand the possible reasons for this issue? I would like to resolve any problems and ensure that the PR meets the repository's requirements.

We just updated our CI progress, and you're the first to test it! Unfortunately, it's not working for external contributors, and I'm not sure why...

You can run tests manually for now by running ./scripts/run_tests.

hiracky16 commented 1 month ago

@Ekrekr Thank you for your assistance.

I have accepted your suggestion and would appreciate another review. 🙏 Additionally, I tried running the tests locally, but they seem to be failing. How can I run tests?

The error message is as follows:

ERROR: /Users/nori/workspace/dataform/test_credentials/BUILD:5:14: Action test_credentials/bigquery.json failed: (Exit 1): gcloud failed: error executing command external/gcloud_sdk/bin/gcloud kms decrypt '--ciphertext-file=test_credentials/bigquery.json.enc' '--plaintext-file=bazel-out/darwin-py2-fastbuild/bin/test_credentials/bigquery.json' ... (remaining 4 arguments skipped)
ERROR: (gcloud.kms.decrypt) PERMISSION_DENIED: Permission 'cloudkms.cryptoKeyVersions.useToDecrypt' denied on resource 'projects/dataform-open-source/locations/global/keyRings/dataform-builder-keyring/cryptoKeys/dataform-builder-key' (or it may not exist).
INFO: Elapsed time: 10.622s, Critical Path: 8.87s
INFO: 19 processes: 17 internal, 2 darwin-sandbox.
FAILED: Build did NOT complete successfully
//common/errors:errors.spec                                           NO STATUS
//common/promises:index.spec                                          NO STATUS
//common/protos:build_test                                            NO STATUS
//common/strings:stringifier.spec                                     NO STATUS
//core:main_test                                                      NO STATUS
//examples:examples_test                                              NO STATUS
//sqlx:format_test                                                    NO STATUS
//sqlx:lexer_test                                                     NO STATUS
//testing:index_test                                                  NO STATUS
//tests/api:api.spec                                                  NO STATUS
//tests/api:projects.spec                                             NO STATUS
//tests/api:utils/cancellable_promise.spec                            NO STATUS
//tests/api:utils/error_parsing.spec                                  NO STATUS
//tests/core:core.spec                                                NO STATUS
//tests/integration:bigquery.spec                                     NO STATUS
//cli:index_test                                                FAILED TO BUILD
//common/flags:build_test                                                PASSED in 0.7s

Executed 1 out of 17 tests: 1 test passes, 1 fails to build and 15 were skipped.
FAILED: Build did NOT complete successfully
Ekrekr commented 1 month ago

Can you share me your gmail account, and I'll grant you permission to decrypt the secret, and to run the CI/CD? Thanks!

hiracky16 commented 1 month ago

@Ekrekr My Gmail account is the same as my GitHub email address. Please share accordingly. If possible, if you could also share the steps to run the CI/CD after the decrypt is shared.

hiracky16 commented 1 month ago

@Ekrekr My Google Account is h.piiice16@gmail.com . Please grant you permission.

Ekrekr commented 1 month ago

@Ekrekr My Google Account is h.piiice16@gmail.com . Please grant you permission.

Hi Noriaki,

I've granted some permissions for people in the dataform-open-source-contributors Google group. If everything works, you should now be able to:

Let me know if this works!

Thanks.

hiracky16 commented 1 month ago

I will reopen the PR because the cla/google CI is failing.