search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
838 stars 160 forks source link

[Dataform][CLI] - dataform install still looks for package.json even when workflow-settings.yaml is available. #1749

Closed Murli16 closed 2 months ago

Murli16 commented 4 months ago

With dataform CLI version - 3.0.0-beta.5

The dataform repo consists of the below folder structure defintions/ workflow_settings.yaml --> This is the new feature introduced to combine dataform.json and package.json I believe

dataform install command returns the below error.

(node:278) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead. (Use node --trace-deprecation ... to show where the warning was created) Dataform encountered an error: Package installation is only supported when specifying @dataform/core version in 'package.json' Error: Package installation is only supported when specifying @dataform/core version in 'package.json'

For now , I have fixed by removing the core version from workflow_settings.yaml and adding package.json.

Could you please let us know if this is a bug ?

Ekrekr commented 2 months ago

This works as intented - the error message is just a bit confusing.

When using workflow_settings.yaml, you never need to run dataform install. Packages are installed at runtime, in a temporary directory. You never see the node_modules folder!

Fix in https://github.com/dataform-co/dataform/pull/1795