search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
853 stars 165 forks source link

fix(1776): dry run of assertions failing #1778

Closed ashish10alex closed 4 months ago

ashish10alex commented 4 months ago

Fixes https://github.com/dataform-co/dataform/issues/1776

The dry of assertion currently fail due to the code expecting the dry run to return at least one row on this line.

Tests

  1. Assertions passing by making the change in the MR. verified by running ./scripts/run run --dry-run <dataform_project_directory>
  2. Assertion when actually ran i.e. using ./scripts/run run ... catches assertion errors
  3. bazel test //core/... passes

PS: This might not be the best solution, but happy to receive guidance