search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
853 stars 165 forks source link

[Enhancement] Support Github Apps as authentication method when linking to Github repositories #1807

Closed penenkel closed 3 months ago

penenkel commented 3 months ago

I would like to use a Github App to establish the authentication when linking Dataform to a Github repository.

At the moment only PATs are supported. Personal access tokens are by definition bound to a person whereas the Dataform-Github connection is more of the machine-to-machine kind. Also, Github only allows the repository owner to generate PATs for it. A third downside to using PATs is that they are comparatively long-lived secrets.

(Ab-)using a separate user account as a service account is no longer recommended by Github (also such an account is subject to licencing-fees). Github recommends "Github App"s for third party service integrations.

Ekrekr commented 3 months ago

We have an open issue for this in the public issue tracker, so closing as duplicate b/304522016

penenkel commented 3 months ago

@Ekrekr Are you certain that that issue tracker is public? It's asking for a login with a google.com account.

penenkel commented 3 months ago

ah the correct link is https://issuetracker.google.com/issues?q=%20304522016