search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
851 stars 163 forks source link

Branch name from master to main #1853

Closed Tuseeq1 closed 1 month ago

Tuseeq1 commented 1 month ago

In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.

diasdauletov commented 1 month ago

In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.

I don't have much knowledge in which cases we run these tests, but I assume these tests should run for any branches. Hence shouldn't this script run tests for master too? (even though we publish on main)

Tuseeq1 commented 1 month ago

No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.

diasdauletov commented 1 month ago

No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.

so do I understand correctly that this scripts run only when we publish from main?

Tuseeq1 commented 1 month ago

yes