search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
848 stars 160 forks source link

compile.ts awaitCompletionOrTimeout throws an unhandled Error on timeout #255

Closed BenBirt closed 5 years ago

BenBirt commented 5 years ago

https://github.com/dataform-co/dataform/blob/master/api/commands/compile.ts#L55

We should really use the technique we use elsewhere, i.e. Promise.race(...).

BenBirt commented 5 years ago

fixed in https://github.com/dataform-co/dataform/commit/7fc5ab8f3de5fb471e61b40f293fb14eafd2f7dc