search

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery
https://cloud.google.com/dataform/docs
Apache License 2.0
834 stars 161 forks source link

double quotes throwing errors in sqlx files #265

Closed dwl285 closed 5 years ago

dwl285 commented 5 years ago

Moved from dataform-co/dataform-co#854 /cc @dwl285

dwl285 commented 5 years ago

@benoitfayolle for tracking

BenBirt commented 5 years ago

After a bit of investigation...

It turns out that PostgresSQL and Snowflake SQL reserve the use of "doubly_quoted_strings" as identifiers (https://docs.snowflake.net/manuals/sql-reference/identifiers-syntax.html, https://www.postgresql.org/docs/9.1/sql-syntax-lexical.html).

So this error was actually Redshift/Postgres/Snowflake complaining that the relevant query(s) were referencing an invalid identifier name correctly.

Thus, closing as there's no bug to fix here, it's up to the SQL variant belonging to the user's choice of warehouse.