refactor: session_ctx.client_ip refactor to Option<String> - Githubissues

datafuselabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com

https://docs.databend.com

Other

7.29k stars 701 forks source link

refactor: session_ctx.client_ip refactor to Option<String> #15368

Closed TCeason closed 2 weeks ago

TCeason commented 2 weeks ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

session_ctx.client_ip refactor to Option

Old version client_ip: Option

This appears to be CK-compatible behavior. But the port should be meaningless information.

Fixes #15367

Tests

[x] Unit Test
[x] Logic Test
[ ] Benchmark Test
[ ] No Test - Explain why

Type of change

[ ] Bug Fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
[ ] Documentation Update
[x] Refactoring
[ ] Performance Improvement
[ ] Other (please describe):

This change is