Closed jyz0309 closed 2 years ago
Thanks for the contribution! I have applied any labels matching special text in your PR Changelog.
Please review the labels and make any necessary changes.
Hello @jyz0309, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.
Merging #1649 (5bfb9fe) into master (fd1c308) will increase coverage by
0%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1649 +/- ##
========================================
Coverage 72% 73%
========================================
Files 521 543 +22
Lines 31533 33125 +1592
========================================
+ Hits 22997 24439 +1442
- Misses 8536 8686 +150
Impacted Files | Coverage Δ | |
---|---|---|
common/flights/src/store_do_action.rs | 92% <ø> (+2%) |
:arrow_up: |
store/src/executor/action_handler.rs | 59% <ø> (ø) |
|
...ry/src/datasources/remote/store_client_provider.rs | 0% <0%> (-100%) |
:arrow_down: |
query/src/datasources/remote/remote_factory.rs | 43% <0%> (-48%) |
:arrow_down: |
...mmon/functions/src/aggregates/aggregator_common.rs | 61% <0%> (-20%) |
:arrow_down: |
common/datavalues/src/arrays/ops/cast.rs | 57% <0%> (-18%) |
:arrow_down: |
common/datavalues/src/types/data_type_coercion.rs | 67% <0%> (-13%) |
:arrow_down: |
query/src/common/hash_table_entity.rs | 66% <0%> (-10%) |
:arrow_down: |
common/datavalues/src/data_value_ops.rs | 40% <0%> (-8%) |
:arrow_down: |
common/datablocks/src/data_block_test.rs | 93% <0%> (-7%) |
:arrow_down: |
... and 150 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd1c308...5bfb9fe. Read the comment docs.
It seems that the failure is not caused by me. How to rerun it? @BohuTANG
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Remove
common/store-api/session_api.rs
Changelog
Related Issues
Fixes #1639
Test Plan
Unit Tests
Stateless Tests