Closed BohuTANG closed 2 years ago
Thanks for the contribution! I have applied any labels matching special text in your PR Changelog.
Please review the labels and make any necessary changes.
Merging #1691 (b4f3851) into master (f0fa13a) will increase coverage by
0%
. The diff coverage is95%
.
@@ Coverage Diff @@
## master #1691 +/- ##
======================================
Coverage 72% 72%
======================================
Files 576 577 +1
Lines 33880 33940 +60
======================================
+ Hits 24464 24536 +72
+ Misses 9416 9404 -12
Impacted Files | Coverage Δ | |
---|---|---|
query/src/catalogs/impls/database_catalog.rs | 78% <37%> (-6%) |
:arrow_down: |
query/src/sql/sql_parser.rs | 76% <83%> (-1%) |
:arrow_down: |
query/src/sql/sql_parser_test.rs | 93% <97%> (+<1%) |
:arrow_up: |
common/planners/src/plan_database_create.rs | 88% <100%> (+1%) |
:arrow_up: |
common/planners/src/plan_display_test.rs | 93% <100%> (+<1%) |
:arrow_up: |
common/planners/src/plan_table_create.rs | 90% <100%> (+14%) |
:arrow_up: |
query/src/datasources/local/local_meta_backend.rs | 81% <100%> (+3%) |
:arrow_up: |
query/src/datasources/tests.rs | 96% <100%> (ø) |
|
query/src/sql/plan_parser.rs | 74% <100%> (-1%) |
:arrow_down: |
query/src/sql/sql_statement.rs | 75% <100%> (ø) |
|
... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f0fa13a...b4f3851. Read the comment docs.
Hello @BohuTANG, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
CI Passed Reviewer Approved Let's Merge
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
This PR including:
example
how to add a new datasource
Changelog
Related Issues
Fixes #1683
Test Plan
Unit Tests
Stateless Tests