search

datafusion-contrib / arrow-zarr

Implementation of Zarr file format in Rust
Apache License 2.0
10 stars 1 forks source link

style: fix formatting and clippy nags #4

Closed tshauck closed 7 months ago

tshauck commented 8 months ago

also adds .github tests

before this is merged, I'll need to update the build actions so that the formatting tests aren't run every push, and more like pushes to main and open PRs.

maximedion2 commented 7 months ago

So to confirm, were you able to run the tests now (after rebasing and after I made the test-data repo public)?

tshauck commented 7 months ago
image
maximedion2 commented 7 months ago

also adds .github tests

before this is merged, I'll need to update the build actions so that the formatting tests aren't run every push, and more like pushes to main and open PRs.

Is there still something you want to update? Looking at the file, it seems like it's still running on all pushes, I do thing only running on PRs to main would make sense?

tshauck commented 7 months ago

Yep, should be updated. I just have it do all PRs, feels like a pretty rare occurrence of a PR into a non-main branch anyways 🤷

maximedion2 commented 7 months ago

Yep, should be updated. I just have it do all PRs, feels like a pretty rare occurrence of a PR into a non-main branch anyways 🤷

Yeah that's fine, works for me, merging now!