support aws_config::load_from_env and fix CI

datafusion-contrib / datafusion-objectstore-s3

S3 as an ObjectStore for DataFusion

Apache License 2.0

59 stars 13 forks source link

support aws_config::load_from_env and fix CI #17

Closed seddonm1 closed 2 years ago

seddonm1 commented 2 years ago

addresses https://github.com/datafusion-contrib/datafusion-objectstore-s3/issues/5 (and replaces https://github.com/datafusion-contrib/datafusion-objectstore-s3/pull/14)
fixes CI tests
update README

matthewmturner commented 2 years ago

@seddonm1 looks great - thank you. for my information, was the issue with CI related to credentials?

seddonm1 commented 2 years ago

@matthewmturner no. You had errors with package names. I'm not sure how you managed to make this work locally? All good 👍

matthewmturner commented 2 years ago

@seddonm1 hm, i had the package names fixed in my PR but was still having issues with it. oh well - im just glad to have it working now. thanks again.