search

datafusion-contrib / datafusion-objectstore-s3

S3 as an ObjectStore for DataFusion
Apache License 2.0
59 stars 13 forks source link

Implement Default on AmazonS3FileSystem #31

Closed matthewmturner closed 2 years ago

matthewmturner commented 2 years ago

Use default AWS credentials provider in a Default impl for AmazonS3Filesystem so we can call

AmazonS3FileSystem::default().await

instead of

AmazonS3FileSystem::new(
        None,
        None,
        None,
        None,
        None,
        None,
    )
    .await,
matthewmturner commented 2 years ago

@seddonm1 what do you think?

seddonm1 commented 2 years ago

yes would be good 👍