search

datafusion-contrib / datafusion-objectstore-s3

S3 as an ObjectStore for DataFusion
Apache License 2.0
59 stars 13 forks source link

Add default function to AmazonS3FileSystem #33

Closed matthewmturner closed 2 years ago

matthewmturner commented 2 years ago

I dont think this worked well with implementing the Default trait because making a new AmazonS3FileSystem is async, so i just added a default function. Let me know if any issues or if im missing something that i could have done with the Default trait.

matthewmturner commented 2 years ago

@seddonm1 think we're good here?

seddonm1 commented 2 years ago

@matthewmturner yes. merge it.