search

datafusion-contrib / datafusion-orc

Implementation of Apache ORC file format use Apache Arrow in-memory format
Apache License 2.0
33 stars 8 forks source link

Crate for generating proto.rs from orc_proto.proto #3

Closed Jefffrey closed 8 months ago

codecov[bot] commented 8 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

WenyXu commented 8 months ago

How about generating the file in build.rs? Such as this example

Jefffrey commented 8 months ago

How about generating the file in build.rs? Such as this example

Yeah I did consider this initially, but I decided to follow the pattern set by arrow-flight as the proto file wouldn't often change

Jefffrey commented 8 months ago

Would it update the generated files automatically?

We'll need to run the regen.sh manually whenever we put in updated proto file

Probably wouldn't happen too often

waynexia commented 8 months ago

Okay.

I'm going to ignore the failed CI due most of changes are generated