datafusion-contrib / datafusion-orc

Implementation of Apache ORC file format use Apache Arrow in-memory format
Apache License 2.0
30 stars 8 forks source link

Remove Cargo.lock, add to .gitignore #40

Closed Jefffrey closed 7 months ago

Jefffrey commented 7 months ago

Generally for libraries the recommendation was to not check in the lock file:

https://doc.rust-lang.org/1.71.1/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Although this guideline has loosened recently:

https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

I think we should remove Cargo.lock from the repo, especially as it is adding unnecessary noise to PR when dependencies change. Happy to hear your thoughts if otherwise :+1: