search

datafusion-contrib / datafusion-orc

Implementation of Apache ORC file format use Apache Arrow in-memory format
Apache License 2.0
28 stars 8 forks source link

Add integration tests using example files from apache/orc #65

Closed progval closed 3 months ago

progval commented 3 months ago

Should I use apache/orc as a git submodule instead of copying data files here? I figured it's not worth the overhead of submodules, considering they only weigh 24MB.

Some tests are failing, I tried to annotate the reason when I understood. Some (commented with // Why?) look like actual bugs.

Resolves https://github.com/datafusion-contrib/datafusion-orc/issues/27

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.52%. Comparing base (424b021) to head (f6f615b). Report is 45 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== + Coverage 77.22% 80.52% +3.29% ========================================== Files 34 30 -4 Lines 3302 3106 -196 ========================================== - Hits 2550 2501 -49 + Misses 752 605 -147 ```
Jefffrey commented 3 months ago

Thanks for this, I'll take a look soon 👍

Jefffrey commented 3 months ago

Thanks for this @progval :heart: