search

datafusion-contrib / datafusion-orc

Implementation of Apache ORC file format use Apache Arrow in-memory format
Apache License 2.0
28 stars 8 forks source link

tests/integration/: Add support for decoding binaries #67

Closed progval closed 3 months ago

progval commented 3 months ago

This goes in the direction opposite to #66, but I already had the code so it doesn't hurt. (At worst it can be deleted when implementing #66)

Also fixes the comment on decimal

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.52%. Comparing base (424b021) to head (873c07a). Report is 46 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== + Coverage 77.22% 80.52% +3.29% ========================================== Files 34 30 -4 Lines 3302 3106 -196 ========================================== - Hits 2550 2501 -49 + Misses 752 605 -147 ```
Jefffrey commented 3 months ago

FYI will go with this approach https://github.com/datafusion-contrib/datafusion-orc/pull/73

So won't have to muck about with JSON parsing

progval commented 3 months ago

Sounds good!