datafusion-contrib / datafusion-orc

Implementation of Apache ORC file format use Apache Arrow in-memory format
Apache License 2.0
28 stars 8 forks source link

Error instead of panic on timestamp overflow #91

Closed progval closed 1 month ago

progval commented 1 month ago

I would have prefered either returning a null value or trying to encode as a non-nanosecond timestamp (sometimes possible if the ORC data does not use nanosecond-level precision), but this would require more significant changes to the code.

waynexia commented 1 month ago

Great 👍 I'm going to merge this

Jefffrey commented 1 month ago

Thanks for this :+1: