search

datafusion-contrib / datafusion-wasm-bindings

WASM bindings for DataFusion
Apache License 2.0
6 stars 1 forks source link

Question about OpenDAL path dependence #4

Open Xuanwo opened 2 months ago

Xuanwo commented 2 months ago

Hi, @waynexia, this project is so cool! I'm so happy that opendal's work on object_store integration and wasm target paid back.

However, I noticed that opendal is path dependence:

opendal = { version = "0.45.0", path = "../opendal/core", default-features = false, features = [
    "services-s3",
    "services-http",
] }
object_store_opendal = { path = "../opendal/integrations/object_store", default-features = false }

Would you like to list the changes you made in opendal? I'm happy to get them upstream and released.

(Maybe @wenyxu and @tisonkun also interested in this issue?)

waynexia commented 2 months ago

Ahh, those are some debugging code in development. The content has not changed.

But I do have one change want to include in the upstream, which makes it easier to use in not !Send codebase like DF.

Cross reference https://github.com/apache/opendal/issues/4437