Apparition d'un membre d'une orga plusieurs fois

IshanB commented 5 years ago

Description du bug

Julien-Pierre Durand apparaît plusieurs fois en tant que membre de l'organisation Saint-Etienne

Comment reproduire le bug

Peut-être dû aux pbs de timeout actuels de datagouv ?

jdesboeufs commented 5 years ago

Apparemment un retour de https://github.com/etalab/data.gouv.fr/issues/1

abulte commented 5 years ago

A fin de debug, le détail des membres sur l'organisation. Les doublons ont été ajoutés dans la même seconde ou presque. Il me semble pourtant qu'on avait blindé le process au niveau de l'ajout de membres...

[(datetime.datetime(2019, 1, 8, 16, 48, 10, 841000), <User: Mehdi CHEBIRA>), (datetime.datetime(2019, 1, 9, 9, 35, 13, 692000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 175000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 259000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 368000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 463000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 558000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 19, 674000), <User: Julien-Pierre DURAND>), (datetime.datetime(2019, 1, 9, 9, 35, 20, 974000), <User: Julien-Pierre DURAND>)]

abulte commented 5 years ago

En creusant un peu, j'ai retracé la source dans nos logs Nginx. Il y a deux problèmes :

Comment on peut arriver à autant de requêtes quasi-simultanées sur les mêmes actions ? Bug front ou client étrange ?
La route "ajout de membre" a l'air bien protégée contre ce genre de cas (renvoie 409) mais pas celle de "accept membership".

[09/Jan/2019:09:35:13 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:19 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:21 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/membership/08a4b4ac-2358-4448-9ad0-955af54754e6/accept/ HTTP/1.1" 200 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:38 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:56 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:59 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:35:59 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:00 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:01 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:01 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:01 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:01 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:01 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:03 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:36:11 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:37:59 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:00 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:00 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:00 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:00 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:16 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:16 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:17 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:17 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:22 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"
[09/Jan/2019:09:38:22 +0100] "POST /api/1/organizations/5c34c63a8b4c41718c8b236f/member/5c34cc218b4c41140276d278 HTTP/1.1" 409 343 "https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0"

abulte commented 5 years ago

TODO:

isoler l'éventuel problème sur le front
repasser la migration https://github.com/opendatateam/udata/blob/master/udata/migrations/2017-07-07-deduplicate-org-members.js une fois le fix https://github.com/opendatateam/udata/pull/1984 déployé

abulte commented 4 years ago

Repasser la migration et attendre

agarrone commented 1 year ago

@maudetes d'actualité ? Apparemment : https://www.data.gouv.fr/fr/admin/organization/5c34c63a8b4c41718c8b236f/

agarrone commented 1 year ago

So far so good

datagouv / data.gouv.fr

Apparition d'un membre d'une orga plusieurs fois #117

Description du bug

Comment reproduire le bug