datagov-cz / mission-control

Tento repozitář je udržován v rámci projektu OPZ č. CZ.03.4.74/0.0/0.0/15_025/0013983.
MIT License
2 stars 1 forks source link

[#125] Forms and dialogs UX improvements #128

Closed karelklima closed 3 years ago

karelklima commented 3 years ago

Done:

Notes:

Resolves #125

psiotwo commented 3 years ago

Maybe not related, but when speaking about UX:

image

karelklima commented 3 years ago
  • The blending-out (or how to call it) is nice (seems planar) for the "Vytvorit pracovni prostor" , while it looks strange for "Editovat pojmy" (it looks like an ex-centric circle)

Fixed. Google calls that the ripple effect. It should always start from the center of buttons now.

  • workspaceRunInTools localization seems missing

Fixed, changed to Actions (which makes more sense given the wording of action buttons).

Maybe not related, but when speaking about UX:

  • Should not the Request feature & Language combo boxes should be visually consistent (same color (orange) of the button and of the options in the former case, while different (blue x gray) in the latter). The same probably holds for the Advanced button on vocabulary detail

image

The combo boxes / buttons are consistent across the whole app, EXCEPT for the one orange button, and the reason why it's a different color is that people notice that. Eventually we may choose to replace the orange color with something different, I personally consider it as a shortcut for beta-testing purposes. Regarding the orange panel after combo box click - that's an antipattern really, what should happen is that the primary label of the button would be replaced by an option from the combo box, but we are misusing the combobox component a bit for our use case.

psiotwo commented 3 years ago

Fixed. Google calls that the ripple effect. It should always start from the center of buttons now.

Well, it is visually more appealing to me, but now I can see it is weird to me as well as the click position is unrelated to the position of the effect. Damn.

I have no more opinions here. Any suggestion here by our Chief Executive Critic @MichalMed?

The combo boxes / buttons are consistent across the whole app, EXCEPT for the one orange button, and the reason why it's a different color is that people notice that. Eventually we may choose to replace the orange color with something different, I personally consider it as a shortcut for beta-testing purposes. Regarding the orange panel after combo box click - that's an antipattern really, what should happen is that the primary label of the button would be replaced by an option from the combo box, but we are misusing the combobox component a bit for our use case.

Agree. :+1:

karelklima commented 3 years ago

@psiotwo The ripple can be disabled altogether, but it is kind of nice that you get the click feedback.