datagov-cz / ontoGrapher

Tento repozitář je udržován v rámci projektu OPZ č. CZ.03.4.74/0.0/0.0/15_025/0013983.
Mozilla Public License 2.0
2 stars 2 forks source link

Change canvas background color #233

Open jakubklimek opened 3 years ago

jakubklimek commented 3 years ago

This is just an opinion, but I think the canvas background color should be white, not gray. Especially on low-res monitors and videocalls, the gray background looks... not so nice.

Is there any special reason for gray?

image image

bindeali commented 3 years ago

Technically, it can be any color we want (it could even be an image). It makes sense to me that the canvas "space" should be visually distinguishable from the panels, and in my admittedly completely personal opinion, I prefer the grey color (in addition, a white background probably wouldn't mesh very well with the term colors turned off, but we can obviously alter that as well). We can change the panel colors or introduce appropriate borders to the styling too.

Tagging @opendata-mvcr/c5-frontend-reviewers for others' opinions.

karelklima commented 3 years ago

I agree with both of you :-) We could experiment with making the grey background a little lighter, but what I think that could work best is if we switched the colors completely - do white canvas and grey panels. The diagrams would pop out visually.

As a hotfix we could do some kind of toggle to turn on white background, but having toggles is not really great, UX-wise.

jakubklimek commented 3 years ago

I do not think this needs to be hotfixed, just thought through. Screenshots in papers and articles need white background also and I do not see the advantage of having it gray.

psiotwo commented 3 years ago

The white background is reasonable IMO. Unrelated - we can consider also dark mode for our tools ...