search

datagov-cz / ontoGrapher

Tento repozitář je udržován v rámci projektu OPZ č. CZ.03.4.74/0.0/0.0/15_025/0013983.
Mozilla Public License 2.0
2 stars 2 forks source link

Published model.ttl contains duplicated restrictions #402

Closed martinnec closed 2 years ago

martinnec commented 2 years ago

This issue does not block my works. It just makes the models strange.

There are many duplicities in the published model.ttl

E.g. in https://slovník-test.mvcr.gov.cz/modelujeme/workspace/instance1511180024 published in https://github.com/opendata-mvcr/ssp/pull/431

There are also many empty restrictions starting at https://github.com/opendata-mvcr/ssp/blob/0c312682dc148e72c2db758788d59c4b08051c9e/content/vocabularies/d-sgov-test-isssue-402/d-sgov-test-isssue-402-model.ttl#L224

Moreover, isn't it an error to say both:

https://github.com/opendata-mvcr/ssp/blob/0c312682dc148e72c2db758788d59c4b08051c9e/content/vocabularies/d-sgov-test-isssue-402/d-sgov-test-isssue-402-model.ttl#L194

and

https://github.com/opendata-mvcr/ssp/blob/0c312682dc148e72c2db758788d59c4b08051c9e/content/vocabularies/d-sgov-test-isssue-402/d-sgov-test-isssue-402-model.ttl#L197

i.e. that both someValuesFrom and allValuesFrom are X? If I say that allValuesFrom are X then it also holds that someValuesFrom are X. Therefore, someValuesFrom is useless?

MichalMed commented 2 years ago

Problém není kompletně vyřešen, duplicity zmizely pouze u typu objektu, o statních typů zůstaly.