search

datagrok-ai / public

Public package repository for the Datagrok.ai platform
MIT License
45 stars 26 forks source link

#2987: Add new columns dialog: filter out irrelevant functions from suggestions dropdown #2987

Open katerina-stepanova opened 3 months ago

katerina-stepanova commented 3 months ago

1.20.1, power pack 1.1.10

Function suggestions still contain too much irrelevant entries, that might be confusing for a regular user. For example, packages:

image image

Expected results: Define which functions are actually useful in calculated columns, filter out all irrelevant ones. For packages: are there any real use cases? If not, it might be more useful to filter it out completely.

dnillovna commented 3 months ago

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16492

LesiaPavlenko commented 1 month ago

v. 1.21.1 PowerPack v.1.2.0 We are waiting for feedback about filtering

katerina-stepanova commented 1 month ago

v. 1.21.1 PowerPack v.1.2.0

There are still a lot of irrelevant functions:

Some of these appear in suggestions dropdown, some are present only in the right side panel.

MariaDolotova commented 4 weeks ago

Hi @katerina-stepanova , I agree regarding the follwoing functions: Call, DeployPackageVersion, JS. They should be marked as internal and not be included into the list.

But as for DBScalarQuery - as far as I know, it can be used in the 'Add new column' dialog. As well as package functions. I mean, potentially any function which returns some scalar value (or a vector function which returns column and is marked by special tag) can be used in 'Add new column'. Moreover, ability to use package functions straight from 'Add new column' dialog is an improvement itself.

Basically, we introduced different kinds of filtrations, sortings and hints to help user to navigate through the list of functions easily. Like autocompletion filtering as you type, functions filtering by categories (using checkboxes), functions search. Also if you click on a column in a column list, functions in the right widget will be sorted with the most relevant once on top.

Maybe I do not fully understand why would wider list of functions confuse users. Considering all available hints...