Force strings from stream for the infer strings strategy

datahq / dataflows

DataFlows is a simple, intuitive lightweight framework for building data processing flows in python.

https://dataflows.org

MIT License

194 stars 39 forks source link

Force strings from stream for the infer strings strategy #115

Closed roll closed 4 years ago

roll commented 4 years ago

fixes https://github.com/BCODMO/frictionless-usecases/issues/27

@akariv Without this change in the load processor, the added test fails which doesn't seem the correct behavior. I also had to update the strategies test. Please take a look at the issue above for more info about where it popped up.

WDYT?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 401

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 84.623%

Totals
Change from base Build 397:	0.02%
Covered Lines:	1651
Relevant Lines:	1951

💛 - Coveralls

akariv commented 4 years ago

Yes, this makes sense.

Thanks!