Closed roll closed 4 years ago
@akariv Please take a look.
It seems to have fixed the resource.hash/bytes
problem but I'm still not sure what's going on with package.hash/bytes
(and what it is actually). I've added a few todos regarding it
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dataflows/processors/dumpers/file_dumper.py | 6 | 7 | 85.71% | ||
<!-- | Total: | 6 | 7 | 85.71% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
dataflows/processors/dumpers/file_formats.py | 7 | 79.63% | ||
<!-- | Total: | 7 | --> |
Totals | |
---|---|
Change from base Build 405: | 0.04% |
Covered Lines: | 1662 |
Relevant Lines: | 1962 |
Bytes is for counting the number of bytes (approx.) the package weighs. Hash is for saving the file in a hashed path (that is, re-saving the package in the same location btu with different data won't override the previous data)
@akariv
I didn't get that inc
stands for increment
in the first place.
I've removed the todos. It seems it works correctly.
The PR fixes saving byte count to resources.
Just bumping this issue! I know its holiday season so no real rush but just want to keep this on our radar.
I hope it's ready for a review