Closed roll closed 4 years ago
Totals | |
---|---|
Change from base Build 458: | 0.06% |
Covered Lines: | 1758 |
Relevant Lines: | 2058 |
Totals | |
---|---|
Change from base Build 451: | 0.07% |
Covered Lines: | 1716 |
Relevant Lines: | 2016 |
Hi @akariv @cschloer,
I played a little bit with additional information on exceptions. It partially works but I don't fully understand how flows are composed so this implementation is really limited.
Can be a starting point for a better implementation
This looks good, and pretty much exactly what I was getting at, but I see that it's only limited to processors that inherit the DataStreamProcessor class. Is there any way to extrapolate this out to the flow.py file? So it works by default for all processors, even custom ones that don't inherit any datahq code? I also am not familiar enough with how flows work to get a sense of whether that is possible.
hi @akariv WDYT?
As decided on the prev meeting - it's parked for now to get @akariv input first
@roll - sorry for missing this, it's really great!
Regarding the implementation -
raise ... from e
syntax)DataStreamProcessor
so all should get the position parameter as wellHi @akariv,
I've added the exception objects you mentioned. Also, updated the implementation to make it work with different combinations of processors. TBH not sure how it works but it seems to be working