datahq / dataflows

DataFlows is a simple, intuitive lightweight framework for building data processing flows in python.
https://dataflows.org
MIT License
193 stars 39 forks source link

fix permissions of files created with dump_to_path #164

Closed OriHoch closed 2 years ago

OriHoch commented 2 years ago

Reproduction Steps

Expected

Actual

Explanation

Files created with FileDumper are first created as temporary files which have permissions only for file owner, and are are later copied over to the final location. They are copied with the limited temporary file permissions which is unexpected and limited. This PR fixes it by setting their permissions to the default OS permissions as set by umask.

See more details about this problem and the solution here: https://stackoverflow.com/questions/7150826/how-can-i-get-the-default-file-permissions-in-python

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 552


Totals Coverage Status
Change from base Build 551: 0.04%
Covered Lines: 2175
Relevant Lines: 2562

💛 - Coveralls