Closed OriHoch closed 5 years ago
Totals | |
---|---|
Change from base Build 119: | 0.2% |
Covered Lines: | 1088 |
Relevant Lines: | 1389 |
Totals | |
---|---|
Change from base Build 191: | 0.3% |
Covered Lines: | 1138 |
Relevant Lines: | 1458 |
I'm pretty reluctant to introduce another 'Flow' class with some modified functionality.
What do you think of this pattern (creating a dual use for the cache
processor):
Flow(
cache(
step1(),
step2(),
checkpoint(path='.cache/checkpoint_1'),
step3(),
step4(),
checkpoint(path='.cache/checkpoint_2'),
)
)
# equivalent to
Flow(
cache(
cache(
step1(),
step2(),
path='.cache/checkpoint_1'
),
step3(),
step4(),
path='.cache/checkpoint_2'
)
)
Could incorporate it into flow and get rid of the cache processor altogether
Flow(
step1(),
step2(),
checkpoint(path='.cache/checkpoint_1'),
step3(),
step4(),
checkpoint(path='.cache/checkpoint_2'),
)
Yep, even better.
On Wed, Oct 17, 2018 at 10:36 AM Ori Hoch notifications@github.com wrote:
Could incorporate it into flow and get rid of the cache processor altogether
Flow( step1(), step2(), checkpoint(path='.cache/checkpoint_1'), step3(), step4(), checkpoint(path='.cache/checkpoint_2'), )
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/datahq/dataflows/pull/30#issuecomment-430522433, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQMdZeeyl9p5aQY63zZNV9k-Yf3s_zVks5ult33gaJpZM4XchTb .
@akariv fixed
@akariv fixed
CacheFlow class allows to chain cache steps:
also, simplified implementation of cache processor