datahq / dataflows

DataFlows is a simple, intuitive lightweight framework for building data processing flows in python.
https://dataflows.org
MIT License
195 stars 40 forks source link

Implement full outer join #91

Closed roll closed 5 years ago

roll commented 5 years ago

Hi @akariv,

It's a first attempt to implement full outer join mode as asked here https://github.com/BCODMO/frictionless-usecases/issues/12

If adding this functionality makes sense there are a few questions:

Please take a look

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 327


Changes Missing Coverage Covered Lines Changed/Added Lines %
dataflows/processors/join.py 22 23 95.65%
<!-- Total: 22 23 95.65% -->
Totals Coverage Status
Change from base Build 321: 0.2%
Covered Lines: 1585
Relevant Lines: 1877

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 327


Changes Missing Coverage Covered Lines Changed/Added Lines %
dataflows/processors/join.py 22 23 95.65%
<!-- Total: 22 23 95.65% -->
Totals Coverage Status
Change from base Build 321: 0.2%
Covered Lines: 1585
Relevant Lines: 1877

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 334


Changes Missing Coverage Covered Lines Changed/Added Lines %
dataflows/processors/join.py 29 30 96.67%
<!-- Total: 29 30 96.67% -->
Totals Coverage Status
Change from base Build 321: 0.2%
Covered Lines: 1590
Relevant Lines: 1882

💛 - Coveralls
roll commented 5 years ago

@akariv Thanks for the review. I've made changes and updated the readme. Please take a look.

akariv commented 5 years ago

This looks good @roll, thanks!