Closed roll closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dataflows/processors/join.py | 22 | 23 | 95.65% | ||
<!-- | Total: | 22 | 23 | 95.65% | --> |
Totals | |
---|---|
Change from base Build 321: | 0.2% |
Covered Lines: | 1585 |
Relevant Lines: | 1877 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dataflows/processors/join.py | 22 | 23 | 95.65% | ||
<!-- | Total: | 22 | 23 | 95.65% | --> |
Totals | |
---|---|
Change from base Build 321: | 0.2% |
Covered Lines: | 1585 |
Relevant Lines: | 1877 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dataflows/processors/join.py | 29 | 30 | 96.67% | ||
<!-- | Total: | 29 | 30 | 96.67% | --> |
Totals | |
---|---|
Change from base Build 321: | 0.2% |
Covered Lines: | 1590 |
Relevant Lines: | 1882 |
@akariv Thanks for the review. I've made changes and updated the readme. Please take a look.
mode=half-outer
by default because it seems the only non breaking way to make this updatehalf-outer
or left-outer
or something elseThis looks good @roll, thanks!
Hi @akariv,
It's a first attempt to implement full outer join mode as asked here https://github.com/BCODMO/frictionless-usecases/issues/12
If adding this functionality makes sense there are a few questions:
mode
parameter (inner/half-outer/full-outer
) because thefull
flag can't cover all the options and slightly contradict to the SQL terminologydb_keys
cache. Not sure will it be good enough using memory for DPPPlease take a look